Draft
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
6 tasks
The boot hook tests were failing on CI because they used ProcessHandle::spawn which applies Linux sandbox enforcement (seccomp, landlock, privilege dropping) in a pre_exec hook. On CI containers running as root, drop_privileges tried to switch to the non-existent sandbox user, causing EINVAL. Replace run_test_boot_hook and spawn_test_process with a test-specific implementation using plain tokio::process::Command that exercises boot hook logic without sandbox enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run
/etc/openshell/boot.shas a supervisor-managed startup hook on every sandbox startup before the long-lived child process.Add the shared boot script path constant, cover the hook with startup/failure/regression tests, and document the new sandbox image contract.
Related Issue
None.
Changes
/etc/openshell/boot.shpath inopenshell-policyTesting
mise run pre-commitpassesChecklist